Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make yarn v1 work with react-native-executorch #131

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

chmjkb
Copy link
Contributor

@chmjkb chmjkb commented Mar 10, 2025

Description

Currently, we have react and react-native listed as a dependency in package.json. We also have it listed in devDependencies, which makes the yarn v1 fail when installing the package. Fixes #121

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb merged commit 53c5b0b into main Mar 10, 2025
2 checks passed
@chmjkb chmjkb deleted the @chmjkb/yarn-v1-fix branch March 10, 2025 09:51
JakubGonera pushed a commit that referenced this pull request Mar 12, 2025
## Description
Currently, we have react and react-native listed as a dependency in
package.json. We also have it listed in devDependencies, which makes the
yarn v1 fail when installing the package. Fixes #121

### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on
- [x] iOS
- [x] Android

### Testing instructions
<!-- Provide step-by-step instructions on how to test your changes.
Include setup details if necessary. -->

### Screenshots
<!-- Add screenshots here, if applicable -->

### Related issues
<!-- Link related issues here using #issue-number -->

### Checklist
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [ ] My changes generate no new warnings

### Additional notes
<!-- Include any additional information, assumptions, or context that
reviewers might need to understand this PR. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn add react-native-executorch failed
2 participants